mirror/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git synced 2026-02-05 04:13:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: ssl: Potential NULL deref in trace macro

Browse Source 
'ctx' might be NULL when we exit 'ssl_sock_handshake', it can't be
dereferenced without check in the trace macro.

This was found by Coverity andraised in GitHub #3113.
This patch should be backported up to 3.2
This commit is contained in:
Remi Tricot-Le Breton
2025-10-10 14:16:31 +02:00
committed by Christopher Faulet
parent d82019d05c
commit 6f4ca37880
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ssl_sock.c
View File

@@ -5943,7 +5943,7 @@ reneg_ok:
if (!conn->err_code)
conn->err_code = CO_ER_SSL_HANDSHAKE;
TRACE_ERROR("handshake error", SSL_EV_CONN_HNDSHK|SSL_EV_CONN_ERR, conn, ctx->ssl, &conn->err_code, (ctx ? &ctx->error_code : NULL));
TRACE_ERROR("handshake error", SSL_EV_CONN_HNDSHK|SSL_EV_CONN_ERR, conn, (ctx ? ctx->ssl : NULL), &conn->err_code, (ctx ? &ctx->error_code : NULL));
return 0;
}