From 79f969f6b975714cc20a56911d83145a9889164c Mon Sep 17 00:00:00 2001
From: ReinUsesLisp <reinuseslisp@airmail.cc>
Date: Tue, 21 Aug 2018 14:41:00 -0300
Subject: [PATCH] Address feedback

---
 Ryujinx.Graphics/Gal/Shader/GlslDecompiler.cs | 23 +++++++------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/Ryujinx.Graphics/Gal/Shader/GlslDecompiler.cs b/Ryujinx.Graphics/Gal/Shader/GlslDecompiler.cs
index 6a116fd56..4bd83d5ed 100644
--- a/Ryujinx.Graphics/Gal/Shader/GlslDecompiler.cs
+++ b/Ryujinx.Graphics/Gal/Shader/GlslDecompiler.cs
@@ -439,15 +439,13 @@ namespace Ryujinx.Graphics.Gal.Shader
 
         private void PrintProgram(ShaderIrBlock[] Blocks, string Name)
         {
-            string Ident1 = IdentationStr;
-            string Ident2 = Ident1 + IdentationStr;
-            string Ident3 = Ident2 + IdentationStr;
-            string Ident4 = Ident3 + IdentationStr;
+            const string Ident1 = IdentationStr;
+            const string Ident2 = Ident1 + IdentationStr;
+            const string Ident3 = Ident2 + IdentationStr;
+            const string Ident4 = Ident3 + IdentationStr;
 
             SB.AppendLine(Ident1 + "pc = " + GetBlockPosition(Blocks[0]) + ";");
-
             SB.AppendLine(Ident1 + "do {");
-
             SB.AppendLine(Ident2 + "switch (pc) {");
 
             foreach (ShaderIrBlock Block in Blocks)
@@ -458,13 +456,10 @@ namespace Ryujinx.Graphics.Gal.Shader
             }
 
             SB.AppendLine(Ident3 + "default:");
-
             SB.AppendLine(Ident4 + "pc = 0;");
-
             SB.AppendLine(Ident4 + "break;");
 
             SB.AppendLine(Ident2 + "}");
-
             SB.AppendLine(Ident1 + "} while (pc != 0);");
         }
 
@@ -586,7 +581,7 @@ namespace Ryujinx.Graphics.Gal.Shader
             {
                 ShaderIrNode Last = Nodes[Nodes.Length - 1];
 
-                bool TailBranch = false;
+                bool UnconditionalFlowChange = false;
 
                 if (Last is ShaderIrOp Op)
                 {
@@ -595,15 +590,13 @@ namespace Ryujinx.Graphics.Gal.Shader
                         case ShaderIrInst.Bra:
                         case ShaderIrInst.Exit:
                         case ShaderIrInst.Kil:
-                            TailBranch = true;
+                            UnconditionalFlowChange = true;
                             break;
                     }
                 }
 
-                if (!TailBranch)
+                if (!UnconditionalFlowChange)
                 {
-                    SB.AppendLine(IdentationStr + "// Jump to next block");
-
                     SB.AppendLine(IdentationStr + "return " + GetBlockPosition(Block.Next) + ";");
                 }
             }
@@ -913,7 +906,7 @@ namespace Ryujinx.Graphics.Gal.Shader
 
         private string GetCnumExpr(ShaderIrOp Op) => GetUnaryCall(Op, "!isnan");
 
-        private string GetExitExpr(ShaderIrOp Op) => "return 0";
+        private string GetExitExpr(ShaderIrOp Op) => "return 0u";
 
         private string GetFcosExpr(ShaderIrOp Op) => GetUnaryCall(Op, "cos");