feat core: add some comments detailing what could be improved

This commit is contained in:
purple 2024-05-21 11:12:07 +02:00 committed by GitHub
parent 877c6bf105
commit 57c60c0b09
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -229,6 +229,7 @@ if [[ $1 != "-bash" ]]; then
PRINT INFO "Replacing internal placeholders.." PRINT INFO "Replacing internal placeholders.."
# Update folder placeholder on PlaceholderService and admin layout. # Update folder placeholder on PlaceholderService and admin layout.
# Should avoid doing stuff this way in the future!
sed -i "s~::f~$FOLDER~g" $FOLDER/app/BlueprintFramework/Services/PlaceholderService/BlueprintPlaceholderService.php sed -i "s~::f~$FOLDER~g" $FOLDER/app/BlueprintFramework/Services/PlaceholderService/BlueprintPlaceholderService.php
sed -i "s~::f~$FOLDER~g" $FOLDER/app/BlueprintFramework/Libraries/ExtensionLibrary/Admin/BlueprintAdminLibrary.php sed -i "s~::f~$FOLDER~g" $FOLDER/app/BlueprintFramework/Libraries/ExtensionLibrary/Admin/BlueprintAdminLibrary.php
sed -i "s~::f~$FOLDER~g" $FOLDER/app/BlueprintFramework/Libraries/ExtensionLibrary/Client/BlueprintClientLibrary.php sed -i "s~::f~$FOLDER~g" $FOLDER/app/BlueprintFramework/Libraries/ExtensionLibrary/Client/BlueprintClientLibrary.php
@ -236,6 +237,7 @@ if [[ $1 != "-bash" ]]; then
cp $FOLDER/.blueprint/assets/logo.jpg $FOLDER/.blueprint/extensions/blueprint/assets/logo.jpg cp $FOLDER/.blueprint/assets/logo.jpg $FOLDER/.blueprint/extensions/blueprint/assets/logo.jpg
# Put application into maintenance. # Put application into maintenance.
# Should give users a choice!
PRINT INFO "Put application into maintenance mode." PRINT INFO "Put application into maintenance mode."
php artisan down &>> $BLUEPRINT__DEBUG php artisan down &>> $BLUEPRINT__DEBUG
@ -273,6 +275,7 @@ if [[ $1 != "-bash" ]]; then
if [[ $DOCKER != "y" ]]; then if [[ $DOCKER != "y" ]]; then
# Put application into production. # Put application into production.
# Should give users a choice!
PRINT INFO "Put application into production." PRINT INFO "Put application into production."
php artisan up &>> $BLUEPRINT__DEBUG php artisan up &>> $BLUEPRINT__DEBUG