From 3a21ada5597becd9be9d322f30659b588bc46aa6 Mon Sep 17 00:00:00 2001 From: ChomeNS <95471003+ChomeNS@users.noreply.github.com> Date: Mon, 18 Aug 2025 17:43:03 +0700 Subject: [PATCH] fix: handle extras messages in ExecutorService to prevent bot hang from strangers sending ahh data --- .../chomens_bot/plugins/ExtrasMessengerPlugin.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/me/chayapak1/chomens_bot/plugins/ExtrasMessengerPlugin.java b/src/main/java/me/chayapak1/chomens_bot/plugins/ExtrasMessengerPlugin.java index d53fffc8..317727d3 100644 --- a/src/main/java/me/chayapak1/chomens_bot/plugins/ExtrasMessengerPlugin.java +++ b/src/main/java/me/chayapak1/chomens_bot/plugins/ExtrasMessengerPlugin.java @@ -101,7 +101,11 @@ public class ExtrasMessengerPlugin implements Listener { final byte[] data = readByteArrayToEnd(buf); - bot.listener.dispatch(listener -> listener.onExtrasMessageReceived(uuid, data)); + // you cannot trust any Extras message data because it can be + // really long and can cause the bot to hang for a while + bot.executorService.execute( + () -> bot.listener.dispatch(listener -> listener.onExtrasMessageReceived(uuid, data)) + ); } }