Aurelien DARRAGON fbbc2925d4 BUG/MEDIUM: log/ring: broken syslog octet counting ...

As reported by Tristan in GH #2561, syslog messages sent over rings are
malformed since commit 01aa0a05 ("MEDIUM: ring: change the ring reader
to use the new vector-based API now").

Indeed, take a look at the following log message produced prior to
01aa0a05:

  181 <134>1 2024-05-07T09:45:21.543263+02:00 - haproxy 113700 - - 127.0.0.1:56136 [07/May/2024:09:45:21.491] front front/s1 0/0/21/30/51 404 369 - - ---- 1/1/0/0/0 0/0   "GET / HTTP/1.1"

Starting with 01aa0a05, here's the equivalent log message:

  <134>1 2024-05-07T09:45:21.543263+02:00 - haproxy 112729 - - 127.0.0.1:56136 [07/May/2024:09:45:21.491] front front/s1 0/0/66/39/105 404 369 - - ---- 1/1/0/0/0 0/0   "GET / HTTP/1.1"-fwr

-> Message is missing octet counting header, and garbage bytes are found
at the end of the payload.

This bug is caused by a small mistake in syslog_applet_append_event():
when the function was refactored to use vector API instead of buffer
API, we used 'trash.area' as starting pointer to write the event instead
of 'trash.area + trash.data', causing existing octet counting prefix
(already written in trash) to be overwritten and trash.data to be
wrongly incremented.

No backport needed (01aa0a05 was introduced during 3.0 development)

2024-05-07 19:23:01 +02:00

..

acl.c

…

action.c

…

activity.c

…

applet.c

…

arg.c

…

auth.c

…

backend.c

…

base64.c

…

cache.c

…

calltrace.c

…

cbuf.c

…

cfgcond.c

…

cfgdiag.c

…

cfgparse-global.c

…

cfgparse-listen.c

…

cfgparse-quic.c

…

cfgparse-ssl.c

…

cfgparse-tcp.c

…

cfgparse-unix.c

…

cfgparse.c

…

channel.c

…

check.c

…

chunk.c

…

cli.c

…

clock.c

…

compression.c

…

connection.c

…

cpuset.c

…

debug.c

…

dgram.c

…

dict.c

…

dns_ring.c

…

dns.c

…

dynbuf.c

…

eb32sctree.c

…

eb32tree.c

…

eb64tree.c

…

ebimtree.c

…

ebistree.c

…

ebmbtree.c

…

ebpttree.c

…

ebsttree.c

…

ebtree.c

…

errors.c

…

ev_epoll.c

…

ev_evports.c

…

ev_kqueue.c

…

ev_poll.c

…

ev_select.c

…

event_hdl.c

…

extcheck.c

…

fcgi-app.c

…

fcgi.c

…

fd.c

…

filters.c

…

fix.c

…

flt_bwlim.c

…

flt_http_comp.c

…

flt_spoe.c

…

flt_trace.c

…

freq_ctr.c

…

frontend.c

…

guid.c

…

h1_htx.c

…

h1.c

…

h2.c

…

h3_stats.c

…

h3.c

…

haproxy.c

…

hash.c

…

hlua_fcn.c

…

hlua.c

…

hpack-dec.c

…

hpack-enc.c

…

hpack-huff.c

…

hpack-tbl.c

…

hq_interop.c

…

http_acl.c

…

http_act.c

…

http_ana.c

…

http_client.c

…

http_conv.c

…

http_ext.c

…

http_fetch.c

…

http_htx.c

…

http_rules.c

…

http.c

…

htx.c

…

init.c

…

jwt.c

…

lb_chash.c

…

lb_fas.c

…

lb_fwlc.c

…

lb_fwrr.c

…

lb_map.c

…

lb_ss.c

…

linuxcap.c

…

listener.c

…

log.c

BUG/MEDIUM: log/ring: broken syslog octet counting

2024-05-07 19:23:01 +02:00

lru.c

…

mailers.c

…

map.c

…

mjson.c

…

mqtt.c

…

mux_fcgi.c

…

mux_h1.c

…

mux_h2.c

…

mux_pt.c

…

mux_quic.c

…

mworker-prog.c

…

mworker.c

…

namespace.c

…

ncbuf.c

…

pattern.c

…

payload.c

…

peers.c

…

pipe.c

…

pool.c

…

proto_quic.c

…

proto_rhttp.c

…

proto_sockpair.c

…

proto_tcp.c

…

proto_udp.c

…

proto_uxdg.c

…

proto_uxst.c

…

protocol.c

…

proxy.c

…

qmux_http.c

…

qmux_trace.c

…

qpack-dec.c

…

qpack-enc.c

…

qpack-tbl.c

…

queue.c

…

quic_ack.c

…

quic_cc_cubic.c

…

quic_cc_newreno.c

…

quic_cc_nocc.c

…

quic_cc.c

…

quic_cid.c

…

quic_cli.c

…

quic_conn.c

…

quic_fctl.c

…

quic_frame.c

…

quic_loss.c

…

quic_openssl_compat.c

…

quic_retransmit.c

…

quic_retry.c

…

quic_rx.c

…

quic_sock.c

…

quic_ssl.c

…

quic_stats.c

…

quic_stream.c

…

quic_tls.c

…

quic_tp.c

…

quic_trace.c

…

quic_tx.c

…

raw_sock.c

…

regex.c

…

resolvers.c

…

ring.c

…

sample.c

…

server_state.c

…

server.c

…

session.c

…

sha1.c

…

shctx.c

…

signal.c

…

sink.c

…

slz.c

…

sock_inet.c

…

sock_unix.c

…

sock.c

…

ssl_ckch.c

…

ssl_crtlist.c

…

ssl_gencert.c

…

ssl_ocsp.c

…

ssl_sample.c

…

ssl_sock.c

…

ssl_utils.c

…

stats-file.c

…

stats-html.c

…

stats-json.c

…

stats-proxy.c

…

stats.c

…

stconn.c

…

stick_table.c

…

stream.c

…

systemd.c

…

task.c

…

tcp_act.c

…

tcp_rules.c

…

tcp_sample.c

…

tcpcheck.c

…

thread.c

…

time.c

…

tools.c

…

trace.c

…

uri_auth.c

…

uri_normalizer.c

…

vars.c

…

version.c

…

wdt.c

…

xprt_handshake.c

…

xprt_quic.c

…