mirror of
http://git.haproxy.org/git/haproxy.git
synced 2026-02-08 11:03:36 +02:00
While reading the recent changes around mt_list_for_each_entry_safe() I noticed a spurious "q" at the beginning of a line introduced by commit455843721("CLEANUP: list: Fix mt_list_for_each_entry_safe indentation") and that visually confusing multi-line comments missing the trailing '\' character were introduced by previous commit60cffbaca("MINOR: list: documenting mt_list_for_each_entry_safe() macro"), which at first glance made the macro look broken. In addition, multi-line comments must end with a "*/" on its own line to instantly spot where it ends without having to read the whole line, like this: /* we know from the above that foo is always valid * here so it's safe to end the string: */ *(unsigned char *)foo = 0; Not like this: /* we know from the above that foo is always valid * here so it's safe to end the string: */ *(unsigned char *)foo = 0; Finally, macro's main comment mentionned the wrong macro name and types, and was randomly indented.