Willy Tarreau a9de333aa5 [BUG] stream_sock: BUF_INFINITE_FORWARD broke splice on 64-bit platforms ...

Yohan Tordjman at Dstorage found that upgrading haproxy to 1.4-dev4
caused truncated objects to be returned. An strace quickly exhibited
the issue which was 100% reproducible :

4297  epoll_wait(0, {}, 10, 0)          = 0
4297  epoll_wait(0, {{EPOLLIN, {u32=7, u64=7}}}, 10, 1000) = 1
4297  splice(0x7, 0, 0x5, 0, 0xffffffffffffffff, 0x3) = -1 EINVAL (Invalid argument)
4297  shutdown(7, 1 /* send */)         = 0
4297  close(7)                          = 0
4297  shutdown(2, 1 /* send */)         = 0
4297  close(2)                          = 0

This is caused by the fact that the forward length is taken from
BUF_INFINITE_FORWARD, which is -1. The problem does not appear
in 32-bit mode because this value is first cast to an unsigned
long, truncating it to 32-bit (4 GB). Setting an upper bound
fixes the issue.

Also, a second error check has been added for splice. If EINVAL
is returned, we fall back to recv().

2009-11-28 07:47:10 +01:00

..

acl.c

…

appsession.c

…

backend.c

…

base64.c

…

buffers.c

…

cfgparse.c

[MINOR] server tracking: don't care about the tracked server's mode

2009-11-02 11:08:00 +01:00

checks.c

…

client.c

…

cttproxy.c

…

dumpstats.c

[MINOR] Collect & provide http response codes for frontends, fix backends

2009-10-27 21:56:47 +01:00

ev_epoll.c

…

ev_kqueue.c

…

ev_poll.c

…

ev_select.c

…

ev_sepoll.c

…

fd.c

…

freq_ctr.c

…

haproxy.c

…

hdr_idx.c

…

lb_chash.c

[MEDIUM] build: switch ebtree users to use new ebtree version

2009-10-26 21:10:04 +01:00

lb_fwlc.c

[MEDIUM] build: switch ebtree users to use new ebtree version

2009-10-26 21:10:04 +01:00

lb_fwrr.c

[MEDIUM] build: switch ebtree users to use new ebtree version

2009-10-26 21:10:04 +01:00

lb_map.c

[MEDIUM] build: switch ebtree users to use new ebtree version

2009-10-26 21:10:04 +01:00

log.c

…

memory.c

…

pipe.c

…

proto_http.c

[MINOR] http: create new MSG_BODY sub-states

2009-11-08 13:10:58 +01:00

proto_tcp.c

…

proto_uxst.c

…

protocols.c

…

proxy.c

[MINOR] server tracking: don't care about the tracked server's mode

2009-11-02 11:08:00 +01:00

queue.c

…

rbtree.c

…

regex.c

…

server.c

…

session.c

[MINOR] Collect & provide http response codes for frontends, fix backends

2009-10-27 21:56:47 +01:00

sessionhash.c

…

signal.c

…

standard.c

[MINOR] tools: add hex2i() function to convert hex char to int

2009-11-02 20:12:52 +01:00

stream_interface.c

…

stream_sock.c

[BUG] stream_sock: BUF_INFINITE_FORWARD broke splice on 64-bit platforms

2009-11-28 07:47:10 +01:00

task.c

[MEDIUM] build: switch ebtree users to use new ebtree version

2009-10-26 21:10:04 +01:00

time.c

…

uri_auth.c

…