mirror of
http://git.haproxy.org/git/haproxy.git
synced 2026-02-12 09:32:52 +02:00
7d6270a845
This very old bug is there since the first implementation of newreno congestion algorithm implementation. This was a very bad idea to put a state variable into quic_cc_algo struct which only defines the congestion control algorithm used by a QUIC listener, typically its type and its callbacks. This bug could lead to crashes since BUG_ON() calls have been added to each algorithm implementation. This was revealed by interop test, but not very often as there was not very often several connections run at the time during these tests. Hopefully this was also reported by Tristan in GH #2095. Move the congestion algorithm state to the correct structures which are private to a connection (see cubic and nr structs). Must be backported to 2.7 and 2.6.
80 lines
2.1 KiB
C
80 lines
2.1 KiB
C
/*
|
|
* Fake congestion control algorithm which does nothing except initializing
|
|
* the congestion control window to a fixed value.
|
|
*
|
|
*/
|
|
|
|
#include <haproxy/api-t.h>
|
|
#include <haproxy/quic_conn-t.h>
|
|
#include <haproxy/trace.h>
|
|
|
|
#define TRACE_SOURCE &trace_quic
|
|
|
|
unsigned int quic_cc_nocc_fixed_cwnd;
|
|
|
|
static int quic_cc_nocc_init(struct quic_cc *cc)
|
|
{
|
|
struct quic_path *path;
|
|
|
|
path = container_of(cc, struct quic_path, cc);
|
|
path->cwnd = quic_cc_nocc_fixed_cwnd << 10;
|
|
return 1;
|
|
}
|
|
|
|
static void quic_cc_nocc_slow_start(struct quic_cc *cc)
|
|
{
|
|
}
|
|
|
|
/* Slow start callback. */
|
|
static void quic_cc_nocc_ss_cb(struct quic_cc *cc, struct quic_cc_event *ev)
|
|
{
|
|
TRACE_ENTER(QUIC_EV_CONN_CC, cc->qc);
|
|
TRACE_PROTO("CC nocc", QUIC_EV_CONN_CC, cc->qc, ev, cc);
|
|
TRACE_LEAVE(QUIC_EV_CONN_CC, cc->qc);
|
|
}
|
|
|
|
/* Congestion avoidance callback. */
|
|
static void quic_cc_nocc_ca_cb(struct quic_cc *cc, struct quic_cc_event *ev)
|
|
{
|
|
TRACE_ENTER(QUIC_EV_CONN_CC, cc->qc);
|
|
TRACE_PROTO("CC nocc", QUIC_EV_CONN_CC, cc->qc, ev, cc);
|
|
TRACE_LEAVE(QUIC_EV_CONN_CC, cc->qc);
|
|
}
|
|
|
|
/* Recovery period callback. */
|
|
static void quic_cc_nocc_rp_cb(struct quic_cc *cc, struct quic_cc_event *ev)
|
|
{
|
|
TRACE_ENTER(QUIC_EV_CONN_CC, cc->qc);
|
|
TRACE_PROTO("CC nocc", QUIC_EV_CONN_CC, cc->qc, ev, cc);
|
|
TRACE_LEAVE(QUIC_EV_CONN_CC, cc->qc);
|
|
}
|
|
|
|
static void quic_cc_nocc_state_trace(struct buffer *buf, const struct quic_cc *cc)
|
|
{
|
|
struct quic_path *path;
|
|
|
|
path = container_of(cc, struct quic_path, cc);
|
|
chunk_appendf(buf, " cwnd=%llu", (unsigned long long)path->cwnd);
|
|
}
|
|
|
|
static void (*quic_cc_nocc_state_cbs[])(struct quic_cc *cc,
|
|
struct quic_cc_event *ev) = {
|
|
[QUIC_CC_ST_SS] = quic_cc_nocc_ss_cb,
|
|
[QUIC_CC_ST_CA] = quic_cc_nocc_ca_cb,
|
|
[QUIC_CC_ST_RP] = quic_cc_nocc_rp_cb,
|
|
};
|
|
|
|
static void quic_cc_nocc_event(struct quic_cc *cc, struct quic_cc_event *ev)
|
|
{
|
|
return quic_cc_nocc_state_cbs[QUIC_CC_ST_SS](cc, ev);
|
|
}
|
|
|
|
struct quic_cc_algo quic_cc_algo_nocc = {
|
|
.type = QUIC_CC_ALGO_TP_NOCC,
|
|
.init = quic_cc_nocc_init,
|
|
.event = quic_cc_nocc_event,
|
|
.slow_start = quic_cc_nocc_slow_start,
|
|
.state_trace = quic_cc_nocc_state_trace,
|
|
};
|
|
|