From e112c8a64be8ba2f7d8efb3221ec87a6ec119c54 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Tue, 29 Oct 2019 10:16:11 +0100 Subject: [PATCH] BUILD/MINOR: tools: shut up the format truncation warning in get_gmt_offset() The gcc warning about format truncation in get_gmt_offset() is annoying since we always call it with a valid time thus it cannot fail. However it's true that nothing guarantees that future code reuses this function incorrectly in the future, so better enforce the modulus on one day and shut the warning. --- src/standard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/standard.c b/src/standard.c index 08a2c0d46..442348c4a 100644 --- a/src/standard.c +++ b/src/standard.c @@ -3018,11 +3018,12 @@ const char *get_gmt_offset(time_t t, struct tm *tm) } else { *gmt_offset = '+'; } + diff %= 86400U; diff /= 60; /* Convert to minutes */ snprintf(gmt_offset+1, 4+1, "%02d%02d", diff/60, diff%60); } - return gmt_offset; + return gmt_offset; } /* gmt2str_log: write a date in the format :