mirror/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git synced 2026-02-18 02:26:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: task: stop abusing the nice field to detect a tasklet

Browse Source 
It's cleaner to use a flag from the task's state to detect a tasklet
and it's even cheaper. One of the best benefits is that this will
allow to get the nice field out of the common part since the tasklet
doesn't need it anymore. This commit uses the last task bit available
but that's temporary as the purpose of the change is to extend this.
This commit is contained in:
Willy Tarreau
2021-03-02 15:54:11 +01:00
parent 1adaddb494
commit db4e238938
3 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
include/haproxy/task.h
View File

@@ -83,7 +83,7 @@
#define TIMER_LOOK_BACK (1U << 31)
/* tasklets are recognized with nice==-32768 */
#define TASK_IS_TASKLET(t) ((t)->nice == -32768)
#define TASK_IS_TASKLET(t) ((t)->state & TASK_F_TASKLET)
/* a few exported variables */
@@ -435,15 +435,15 @@ static inline struct task *task_init(struct task *t, unsigned long thread_mask)
return t;
}
/* Initialize a new tasklet. It's identified as a tasklet by ->nice=-32768. It
* is expected to run on the calling thread by default, it's up to the caller
* to change ->tid if it wants to own it.
/* Initialize a new tasklet. It's identified as a tasklet by its flags
* TASK_F_TASKLET. It is expected to run on the calling thread by default,
* it's up to the caller to change ->tid if it wants to own it.
*/
static inline void tasklet_init(struct tasklet *t)
{
t->nice = -32768;
t->nice = 0;
t->calls = 0;
t->state = 0;
t->state = TASK_F_TASKLET;
t->process = NULL;
t->tid = -1;
#ifdef DEBUG_TASK