Files
forgejo/tests/integration/webhook_test.go
Gusted a4642af51a feat: replace cross origin protection (#9830)
Replace the anti-CSRF token with a [cross origin protection by Go](https://go.dev/doc/go1.25#nethttppkgnethttp) that uses a stateless way of verifying if a request was cross origin or not. This allows is to remove al lot of code and replace it with a few lines of code and we no longer have to hand roll this protection. The new protection uses indicators by the browser itself that indicate if the request is cross-origin, thus we no longer have to take care of ensuring the generated CSRF token is passed back to the server any request by the the browser will have send this indicator.

Resolves forgejo/forgejo#3538

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9830
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
2025-10-29 22:43:22 +01:00

184 lines
6.1 KiB
Go

// Copyright 2024 The Forgejo Authors c/o Codeberg e.V.. All rights reserved.
// SPDX-License-Identifier: MIT
package integration
import (
"net/http"
"net/url"
"testing"
"forgejo.org/models/db"
repo_model "forgejo.org/models/repo"
"forgejo.org/models/unittest"
user_model "forgejo.org/models/user"
webhook_model "forgejo.org/models/webhook"
"forgejo.org/modules/git"
"forgejo.org/modules/gitrepo"
"forgejo.org/modules/json"
webhook_module "forgejo.org/modules/webhook"
"forgejo.org/services/release"
"forgejo.org/tests"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestWebhookPayloadRef(t *testing.T) {
onApplicationRun(t, func(t *testing.T, giteaURL *url.URL) {
w := unittest.AssertExistsAndLoadBean(t, &webhook_model.Webhook{ID: 1})
w.HookEvent = &webhook_module.HookEvent{
SendEverything: true,
}
require.NoError(t, w.UpdateEvent())
require.NoError(t, webhook_model.UpdateWebhook(db.DefaultContext, w))
hookTasks := retrieveHookTasks(t, w.ID, true)
hookTasksLenBefore := len(hookTasks)
session := loginUser(t, "user2")
// create new branch
req := NewRequestWithValues(t, "POST", "user2/repo1/branches/_new/branch/master", map[string]string{
"new_branch_name": "arbre",
"create_tag": "false",
})
session.MakeRequest(t, req, http.StatusSeeOther)
// delete the created branch
req = NewRequestWithValues(t, "POST", "user2/repo1/branches/delete", map[string]string{
"name": "arbre",
})
session.MakeRequest(t, req, http.StatusOK)
// check the newly created hooktasks
hookTasks = retrieveHookTasks(t, w.ID, false)
expected := map[webhook_module.HookEventType]bool{
webhook_module.HookEventCreate: true,
webhook_module.HookEventPush: true, // the branch creation also creates a push event
webhook_module.HookEventDelete: true,
}
for _, hookTask := range hookTasks[:len(hookTasks)-hookTasksLenBefore] {
if !expected[hookTask.EventType] {
t.Errorf("unexpected (or duplicated) event %q", hookTask.EventType)
}
var payload struct {
Ref string `json:"ref"`
}
require.NoError(t, json.Unmarshal([]byte(hookTask.PayloadContent), &payload))
assert.Equal(t, "refs/heads/arbre", payload.Ref, "unexpected ref for %q event", hookTask.EventType)
delete(expected, hookTask.EventType)
}
assert.Empty(t, expected)
})
}
func TestWebhookReleaseEvents(t *testing.T) {
defer tests.PrepareTestEnv(t)()
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
w := unittest.AssertExistsAndLoadBean(t, &webhook_model.Webhook{
ID: 1,
RepoID: repo.ID,
})
w.HookEvent = &webhook_module.HookEvent{
SendEverything: true,
}
require.NoError(t, w.UpdateEvent())
require.NoError(t, webhook_model.UpdateWebhook(db.DefaultContext, w))
hookTasks := retrieveHookTasks(t, w.ID, true)
gitRepo, err := gitrepo.OpenRepository(git.DefaultContext, repo)
require.NoError(t, err)
defer gitRepo.Close()
t.Run("CreateRelease", func(t *testing.T) {
require.NoError(t, release.CreateRelease(gitRepo, &repo_model.Release{
RepoID: repo.ID,
Repo: repo,
PublisherID: user.ID,
Publisher: user,
TagName: "v1.1.1",
Target: "master",
Title: "v1.1.1 is released",
Note: "v1.1.1 is released",
IsDraft: false,
IsPrerelease: false,
IsTag: false,
}, "", nil))
// check the newly created hooktasks
hookTasksLenBefore := len(hookTasks)
hookTasks = retrieveHookTasks(t, w.ID, false)
checkHookTasks(t, map[webhook_module.HookEventType]string{
webhook_module.HookEventRelease: "published",
webhook_module.HookEventCreate: "", // a tag was created as well
webhook_module.HookEventPush: "", // the tag creation also means a push event
}, hookTasks[:len(hookTasks)-hookTasksLenBefore])
t.Run("UpdateRelease", func(t *testing.T) {
rel := unittest.AssertExistsAndLoadBean(t, &repo_model.Release{RepoID: repo.ID, TagName: "v1.1.1"})
require.NoError(t, release.UpdateRelease(db.DefaultContext, user, gitRepo, rel, false, nil))
// check the newly created hooktasks
hookTasksLenBefore := len(hookTasks)
hookTasks = retrieveHookTasks(t, w.ID, false)
checkHookTasks(t, map[webhook_module.HookEventType]string{
webhook_module.HookEventRelease: "updated",
}, hookTasks[:len(hookTasks)-hookTasksLenBefore])
})
})
t.Run("CreateNewTag", func(t *testing.T) {
require.NoError(t, release.CreateNewTag(db.DefaultContext,
user,
repo,
"master",
"v1.1.2",
"v1.1.2 is tagged",
))
// check the newly created hooktasks
hookTasksLenBefore := len(hookTasks)
hookTasks = retrieveHookTasks(t, w.ID, false)
checkHookTasks(t, map[webhook_module.HookEventType]string{
webhook_module.HookEventCreate: "", // tag was created as well
webhook_module.HookEventPush: "", // the tag creation also means a push event
}, hookTasks[:len(hookTasks)-hookTasksLenBefore])
t.Run("UpdateRelease", func(t *testing.T) {
rel := unittest.AssertExistsAndLoadBean(t, &repo_model.Release{RepoID: repo.ID, TagName: "v1.1.2"})
require.NoError(t, release.UpdateRelease(db.DefaultContext, user, gitRepo, rel, true, nil))
// check the newly created hooktasks
hookTasksLenBefore := len(hookTasks)
hookTasks = retrieveHookTasks(t, w.ID, false)
checkHookTasks(t, map[webhook_module.HookEventType]string{
webhook_module.HookEventRelease: "published",
}, hookTasks[:len(hookTasks)-hookTasksLenBefore])
})
})
}
func checkHookTasks(t *testing.T, expectedActions map[webhook_module.HookEventType]string, hookTasks []*webhook_model.HookTask) {
t.Helper()
for _, hookTask := range hookTasks {
expectedAction, ok := expectedActions[hookTask.EventType]
if !ok {
t.Errorf("unexpected (or duplicated) event %q", hookTask.EventType)
}
var payload struct {
Action string `json:"action"`
}
require.NoError(t, json.Unmarshal([]byte(hookTask.PayloadContent), &payload))
assert.Equal(t, expectedAction, payload.Action, "unexpected action for %q event", hookTask.EventType)
delete(expectedActions, hookTask.EventType)
}
assert.Empty(t, expectedActions)
}